Review main Merged

22669[FEATURE] Add a timestamp when downloading an extension

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 07/30/13, 06:26

Commit message

When downloading an extension within the Extension Manager, a
timestamp should be automatically added to the filename.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Wouter Wolters +1
  • Verified V +2
    • Philipp Gampe +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 07/29/13, 18:28

  2. Wouter Wolters commented on patch set 1 V +1 CR +1 07/29/13, 18:39

    Download works fine. Also tested to upload and overwrite an extension. Works also fine, even with a version downloaded twice in the same minute. The filename contains then (1) and the end of the filename. Uploading that extension also works.
  3. Philipp Gampe voted on patch set 1 V +2 CR +2 07/30/13, 01:11

  4. Philipp Gampe merged patch set 2 07/30/13, 01:11

  5. Oliver Hader commented on patch set 2 07/30/13, 06:26

    Unit tests failed - please check them in the testing process of the review as well next time. Thanks! Unit-tests are fixed now already...