Review TYPO3_4-7 Merged

22700[BUGFIX] Syntax error in class.tx_coreupdates_t3skin.php

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 08/03/13, 22:34

Commit message

Fix Syntax Problem: Cannot use [] for reading

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Alexander Opitz +1
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 6

  1. Chris topher updated the commit message in patch set 1 07/30/13, 12:48

  2. Wouter Wolters commented on patch set 2 07/30/13, 12:51

    Thanks Christopher! I copied it from the Forge ticket as I thought that was copied from PHPstorm.
  3. Alexander Opitz voted on patch set 2 CR +1 07/31/13, 22:22

  4. Stefan Neufeind commented on patch set 2 V +2 CR +2 08/03/13, 22:34

    obvious glitch. In 6.x it's without the square-brackets in typo3/sysext/install/Classes/CoreUpdates/T3skinUpdate.php
  5. Stefan Neufeind merged patch set 3 08/03/13, 22:34

  6. Stefan Neufeind commented on patch set 3 08/03/13, 22:34

    Cherry Picked This patchset was cherry picked to change: I9f5be90dbc9aa55475049bd8a8720cab0c321af4