Review main Merged

22746[BUGFIX] Fix EmConfUtility::fixEmConf conflicts generation

Sascha Egerer CR +2 V +2 Normal +55 −53 updated 08/06/13, 18:58

Commit message

EmConfUtility::fixEmConf generates a string instead
of an array for "$emConf['constraints']['conflicts']"

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Sascha Egerer +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Sascha Egerer +1
    • Christian Kuhn +1

Issues 1

Files 2

Review log 12

  1. Mr. Jenkins commented on patch set 1 08/01/13, 09:52

  2. Philipp Gampe voted on patch set 1 CR +1 08/01/13, 14:12

  3. Armin Vieweg voted on patch set 1 V +1 CR +1 08/06/13, 14:57

  4. Christian Kuhn commented on patch set 1 CR -1 08/06/13, 18:26

    No unit test - no merge ... I'll hack up a test for this.
  5. Christian Kuhn uploaded patch set 2 08/06/13, 18:40

  6. Mr. Jenkins commented on patch set 2 08/06/13, 18:41

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/06/13, 18:41

  8. Sascha Egerer commented on patch set 2 V +1 CR +1 08/06/13, 18:54

    Thank you Christian.
  9. Wouter Wolters voted on patch set 2 V +2 CR +2 08/06/13, 18:58

  10. Wouter Wolters merged patch set 3 08/06/13, 18:58

  11. Wouter Wolters commented on patch set 3 08/06/13, 18:58

    Cherry Picked This patchset was cherry picked to change: I37e026569e761b8550a9b0e6a1cb10835f6c899b
  12. Wouter Wolters commented on patch set 3 08/06/13, 18:58

    Cherry Picked This patchset was cherry picked to change: I37e026569e761b8550a9b0e6a1cb10835f6c899b