Review TYPO3_4-7 Merged

22750[TASK] TagBuilders render() method PhpDoc return tag fixed

Daniel Hürtgen CR +2 V +2 Easy +1 −1 updated 08/02/13, 15:25

Commit message

PhpDoc @return of TagBuilders render() method should be
of type 'string' instead of 'void'.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 4

  1. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/01/13, 14:59

  2. Christian Kuhn commented on patch set 1 V +2 CR +2 08/01/13, 14:59

    Ok, not a critical fix, but this one definately won't hurt. If its important for you for some reason, it's merged now.
  3. Christian Kuhn merged patch set 2 08/01/13, 14:59

  4. Michael Stucki commented on patch set 2 08/02/13, 15:25

    Daniel: It seems your name is containing some weird umlout. It's not a normal "ü" for sure. Please check your settings and fix that.