Review main Merged

22829[BUGFIX] Only load folder contents if folder is initialised

Frans Saris CR +2 V +2 Easy +5 −3 updated 10/15/13, 08:00

Commit message

FolderBasedFileCollection::loadContents() has to check if 
the folder is initialised prior to loading the contents to
prevent fatal errors.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jigal van Hemert +1
  • Verified V +2
    • Markus Klein +2
    • Jigal van Hemert +1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 08/05/13, 20:16

  2. Steffen Ritter voted on patch set 1 CR +1 08/21/13, 06:29

  3. Steffen Ritter voted on patch set 1 V +1 10/15/13, 06:21

  4. Steffen Ritter rebased onto patch set 1 10/15/13, 06:21

  5. Steffen Ritter commented on patch set 2 V +1 CR +1 10/15/13, 06:22

    no brainer IMHO
  6. Mr. Jenkins commented on patch set 2 10/15/13, 06:35

  7. Xavier Perseguers voted on patch set 2 CR +1 10/15/13, 06:58

  8. Steffen Ritter commented on patch set 2 CR -1 10/15/13, 06:59

    call to deprecated methods - will push an update
  9. Steffen Ritter commented on patch set 2 CR +1 10/15/13, 07:00

    sorry wrong tab commented
  10. Jigal van Hemert updated the commit message in patch set 2 10/15/13, 07:06

  11. Jigal van Hemert commented on patch set 3 V +1 CR +1 10/15/13, 07:10

    Had to rewrite the commit message, because it mainly described the problem instead of the change/solution.
  12. Markus Klein voted on patch set 3 V +2 CR +2 10/15/13, 07:36

  13. Markus Klein merged patch set 4 10/15/13, 07:36

  14. Markus Klein commented on patch set 4 10/15/13, 07:37

    Cherry Picked This patchset was cherry picked to change: If3ce06cff13595da49abbb6aa99c891969aea692
  15. Mr. Jenkins commented on patch set 3 10/15/13, 08:00