Review main Merged

23021[TASK] Introduce relative line-heights

Felix Kopp CR +2 V +2 Easy +5 −2 updated 08/16/13, 10:08

Commit message

The line-height for the backend was fixed to 14px.
But line-heights should be relative to the font-size.

With this standard line-heights are 1.5 x font-size.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Ingo Pfennigstorf +1
  • Verified V +2
    • Wouter Wolters +2
    • Ingo Pfennigstorf +1

Issues 1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 08/10/13, 12:52

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 08/12/13, 11:23

  3. Felix Kopp commented on patch set 1 08/15/13, 23:52

    This patch should make it into the core. Any objections? Otherwise I will merge on the weekend.
  4. Mattias Nilsson commented on patch set 1 CR -1 08/16/13, 05:50

    Introduce instead of Bring
  5. Ingo Pfennigstorf updated the commit message in patch set 1 08/16/13, 09:54

  6. Mr. Jenkins commented on patch set 2 08/16/13, 09:55

  7. Ingo Pfennigstorf voted on patch set 2 V +1 CR +1 08/16/13, 09:56

  8. Ingo Pfennigstorf commented on patch set 2 08/16/13, 09:56

    Also hat +1 +1 from Christian
  9. Wouter Wolters voted on patch set 2 V +2 CR +2 08/16/13, 10:03

  10. Wouter Wolters merged patch set 3 08/16/13, 10:03

  11. Stefan Neufeind commented on patch set 3 08/16/13, 10:08

    +1