Review main Merged

23098[BUGFIX] excludeFromUpdates flag ignored

Francois Suter CR +2 V +2 Hard +453 −435 updated 08/31/13, 23:08

Commit message

Since the 6.0 Extension Manager, the "excludeFromUpdates" state
is ignored. It should be checked for and the update button in the
list view hidden in such a case.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1

Issues 1

Files 6

Review log 25

  1. Mr. Jenkins commented on patch set 1 08/14/13, 11:54

  2. Francois Suter commented on patch set 1 08/14/13, 11:58

    Note that this does not totally block updates if someone could call up the correct URL. It just does not display the update icon. However I think that this is enough, as it is really more about preventing the accidental upgrade of an extension.
  3. Philipp Gampe voted on patch set 1 V +1 CR +1 08/17/13, 16:03

  4. Stefan Neufeind commented on patch set 1 CR -1 08/18/13, 11:48

    If excluded from update, should we then show an icon that says there is an update available but it can't be installed? The sorting in extension-manager will still take "updateAvailable" into account when sorted by that column, and it would be strange to just not see the icon imho.
  5. Philipp Gampe commented on patch set 1 08/18/13, 13:01

    The sorting was correct for me. We could display a warning icon instead of the update icon.
  6. Francois Suter commented on patch set 1 08/18/13, 18:55

    Stefan, yes I thought about that too (but after sending the patch ;-). I've been busy working on some other patch in the meantime, but I think it's a good idea, so that admins are aware that there is an update. I'll get back with a new patch next week.
  7. Francois Suter uploaded patch set 2 08/21/13, 20:23

  8. Mr. Jenkins commented on patch set 2 08/21/13, 20:24

  9. Francois Suter commented on patch set 2 08/21/13, 20:27

    So here is a revised (and expanded) version. I have added a greyed-out extension update icon to display instead of the usual one. However I discovered that there was no view helper to simply display an icon, without action link. So I have added a new view helper for this (and I realise I forgot to change its phpDoc, so I will update my patch). Perhaps we could keep the regular \TYPO3\CMS\Fluid\ViewHelpers\Be\Buttons\IconViewHelper and simply allow it to have an empty "uri" argument, in which case it displays the icon without link. What do you think? Obviously all this cannot be backported, so I would propose to backport the first version to 6.1 and 6.0, which is still better than allowing updates.
  10. Francois Suter uploaded patch set 3 08/21/13, 20:29

  11. Mr. Jenkins commented on patch set 3 08/21/13, 20:30

  12. Stefan Neufeind commented on patch set 3 08/22/13, 10:44

    @Francois: I agree we can't backport "all that" and maybe could do as you suggest. Changing the VH to accept an empty/no uri instead of creating a new one might be a good idea, as it sounds (didn't look at the code again just yet).
  13. Francois Suter commented on patch set 3 08/23/13, 16:40

    Just pushed a patch for Fluid which would modify the button icon view helper and simplify this patch: https://review.typo3.org/#/c/23281/
  14. Stefan Neufeind commented on patch set 3 08/24/13, 12:31

    23281 is in now, so feel free to simplify this one now
  15. Stefan Neufeind commented on patch set 3 08/26/13, 19:41

    Please update this one regarding the ViewHelper. I think the rest looks easy.
  16. Francois Suter uploaded patch set 4 08/27/13, 20:02

  17. Francois Suter commented on patch set 4 08/27/13, 20:03

    Improved with usage of modified button icon view helper.
  18. Mr. Jenkins commented on patch set 4 08/27/13, 20:04

  19. Stefan Neufeind commented on patch set 4 CR +1 08/27/13, 20:30

    Because the changed VH is used, I noticed that we can only backport this one "as is" if we have the VH down to 6.0 as well. But let's see ...
  20. Francois Suter commented on patch set 4 08/28/13, 19:24

    Stefan, I wouldn't backport as is anyway, since this version adds a new icon. I don't think that this is feasible for minor releases. It's a very real risk of having a broken BE because all icons in the sprite are shifted. For 6.0 and 6.1 I still intend to backport my first version which didn't add the "disabled update" icon.
  21. Stefan Neufeind commented on patch set 4 08/28/13, 19:53

    agreed. fine with me
  22. Philipp Gampe commented on patch set 4 V +1 CR +1 08/31/13, 18:21

    Hover, you can still override the extension via the get extension submodule. This is another bug: #51619
  23. Stefan Neufeind voted on patch set 4 V +2 CR +2 08/31/13, 23:08

  24. Stefan Neufeind merged patch set 5 08/31/13, 23:08

  25. Stefan Neufeind commented on patch set 5 08/31/13, 23:08

    Cherry Picked This patchset was cherry picked to change: I734331d1b85728dc86732f66ad495a9f83cd0aca