Review main Merged

2323[BUGFIX] Installer - Wrong value for CGI

Markus Klein CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

In "Basic Configuration"->"System Information" the wrong value for
"UNIX/CGI" is displayed, when using fcgid.
The reason is that class.tx_install.php uses an old condition
for determining this.

Thanks to Stephan Grossberndt for discovering this.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Stephan Großberndt +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stephan Großberndt +1

Issues 1

Files 1

Review log 15

  1. Ernesto Baschny commented on patch set 1 06/21/11, 18:46

    (2 inline comments)

    class.tx_install.php:603

    Variable should be called "isPhpCgi" or something because its a boolean (and not the "server API's" name).

    class.tx_install.php:610

    This is unrelated to "UNIX", because a CGI can also run under Windows, so the label is also misleading.
  2. Stefan Neufeind commented on patch set 1 06/21/11, 18:46

    Looks good to me, but someone else must approve can't really test it here, but patch seems reasonably small and just takes over what works in other places (see ticket)
  3. Stefan Neufeind commented on patch set 2 06/21/11, 18:46

    Looks good to me, but someone else must approve can't really test it here, but patch seems reasonably small and just takes over what works in other places (see ticket)
  4. Markus Klein uploaded patch set 2 06/21/11, 18:46

  5. Stephan Großberndt commented on patch set 3 06/21/11, 18:46

    Looks good to me, but someone else must approve
  6. Stephan Großberndt commented on patch set 3 06/21/11, 18:46

    No score
  7. Stephan Großberndt commented on patch set 3 06/21/11, 18:46

    Verified; Looks good to me, but someone else must approve
  8. Stefan Neufeind commented on patch set 3 06/21/11, 18:46

    Looks good to me, but someone else must approve
  9. Markus Klein uploaded patch set 3 06/21/11, 18:46

  10. Georg Ringer commented on patch set 2 06/21/11, 18:46

    Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 06/21/11, 18:46

  12. Mr. Jenkins commented on patch set 2 06/21/11, 18:46

  13. Mr. Jenkins commented on patch set 3 06/21/11, 18:46

  14. Jigal van Hemert commented on patch set 3 V 0 06/21/11, 18:46

    by team member; Looks good to me, approved It is almost a no-brainer. Good catch!
  15. Jigal van Hemert merged patch set 3 06/21/11, 18:46