2323[BUGFIX] Installer - Wrong value for CGI
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Stephan Großberndt +1
-
Verified V +2
- Jigal van Hemert +2
- Stephan Großberndt +1
Issues 1
Files 1
Review log 15
-
Ernesto Baschny commented on patch set 1 06/21/11, 18:46
(2 inline comments)class.tx_install.php:603Variable should be called "isPhpCgi" or something because its a boolean (and not the "server API's" name).class.tx_install.php:610This is unrelated to "UNIX", because a CGI can also run under Windows, so the label is also misleading. -
Stefan Neufeind commented on patch set 1 06/21/11, 18:46
Looks good to me, but someone else must approve can't really test it here, but patch seems reasonably small and just takes over what works in other places (see ticket) -
Stefan Neufeind commented on patch set 2 06/21/11, 18:46
Looks good to me, but someone else must approve can't really test it here, but patch seems reasonably small and just takes over what works in other places (see ticket) -
Markus Klein uploaded patch set 2 06/21/11, 18:46
-
Stephan Großberndt commented on patch set 3 06/21/11, 18:46
Looks good to me, but someone else must approve -
Stephan Großberndt commented on patch set 3 06/21/11, 18:46
No score -
Stephan Großberndt commented on patch set 3 06/21/11, 18:46
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 06/21/11, 18:46
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 3 06/21/11, 18:46
-
Georg Ringer commented on patch set 2 06/21/11, 18:46
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 06/21/11, 18:46
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/531/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/21/11, 18:46
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/536/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/21/11, 18:46
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/776/ : SUCCESS -
Jigal van Hemert commented on patch set 3 V 0 06/21/11, 18:46
by team member; Looks good to me, approved It is almost a no-brainer. Good catch! -
Jigal van Hemert merged patch set 3 06/21/11, 18:46