Review main Merged

23394[TASK] Install tool: Refactor db connect configuration settings

Christian Kuhn CR +2 V +2 Hard +182 −88 updated 09/12/13, 11:55

Commit message

Refactor needsExecution() logic to make sure the mandatory settings
(username, password, host, port) are present in LocalConfiguration.php
before trying to establish a database connection using these settings.

This fixes a possible redirect loop if some of the mandatory settings
were not present, but the database connection check still succeeded.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1