Review main Merged

23441[BUGFIX] Cast autoload and classAliasMap to Array

Michel Georgy CR +2 V +2 Easy +2 −2 updated 08/29/13, 12:26

Commit message

If you create an empty ext_autoload.php or an empty classAliasMap.php
file or fail to return an array, NULL is merged with the existing
array which results in NULL for the array $classRegistry or
$aliasToClassNameMapping
This patch casts the required Array(which is possibly NULL) to an
Array to prevent array_merge with NULL values.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Christoph Dörfel +1
    • Kai Ole Hartwig +1
  • Verified V +2
    • Christian Kuhn +2
    • Christoph Dörfel +1
    • Kai Ole Hartwig +1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 08/29/13, 07:39

  2. Christian Kuhn updated the commit message in patch set 1 08/29/13, 08:20

  3. Christian Kuhn commented on patch set 2 CR +1 08/29/13, 08:20

    Sounds reasonable on reading.
  4. Mr. Jenkins commented on patch set 2 08/29/13, 08:20

  5. Kai Ole Hartwig voted on patch set 2 V +1 CR +1 08/29/13, 10:46

  6. Christoph Dörfel voted on patch set 2 V +1 CR +1 08/29/13, 11:33

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 08/29/13, 12:26

  8. Christian Kuhn merged patch set 3 08/29/13, 12:26

  9. Christian Kuhn commented on patch set 3 08/29/13, 12:26

    Cherry Picked This patchset was cherry picked to change: I1887da3a942b17e441338a95cb7da49a17535907
  10. Christian Kuhn commented on patch set 3 08/29/13, 12:26

    Cherry Picked This patchset was cherry picked to change: I1887da3a942b17e441338a95cb7da49a17535907