23482[BUGFIX] Extend Share font character set
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Ernesto Baschny +1
-
Verified V +2
- Jigal van Hemert +2
- Ernesto Baschny +1
Issues 1
Files 18
- typo3/sysext/t3skin/Resources/Public/Css/visual/fonts.css+12 −1
- typo3/sysext/t3skin/Resources/Public/Fonts/generator_config.txt+1 −1
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.eotbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.svg+664 −218
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.ttfbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.woffbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bolditalic-webfont.eotnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bolditalic-webfont.svgnew+665 −0
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bolditalic-webfont.ttfnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bolditalic-webfont.woffnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.eotbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.svg+653 −220
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.ttfbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.woffbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.eotbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.svg+668 −220
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.ttfbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.woffbinary
Review log 13
-
Mr. Jenkins commented on patch set 1 08/30/13, 01:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10408/ : SUCCESS -
Markus Klein voted on patch set 1 CR +1 08/30/13, 12:57
-
Markus Klein voted on patch set 1 V +2 CR +2 08/30/13, 13:29
-
Ernesto Baschny commented on patch set 1 08/30/13, 15:02
Jigal, the fonts.css adaption for the share-italics is missing. And on the other side I wonder why the file sizes exploded so much. Isn't there a way to "compress" these a bit more? Compare: share-bold-webfont.eot: 22K => 150K share-bold-webfont.svg: 48K => 278K share-bold-webfont.ttf: 45K => 150K share-bold-webfont.woff: 25K => 65K Thats a huge difference, and I cannot imagine that it comes just from the new glyphs? How many glyphs were included in the old version? -
Jigal van Hemert commented on patch set 1 08/30/13, 15:33
@Ernesto: As the commit message says this was not about the styling of backend, but about extending the fonts that were used. I don't want to get in the way of the UX/UI/skin team(s). I just checked the regular fonts and the old one had 215 glyphs, the new one has 667 glyphs. That seems consistent with the increase in size of the TTF file. The fontsquirrel.com tool has changed a bit, so I tried to use the same settings as in the file generator_config.txt. Both in the old and the new situation "eot lite" was selected, but the EOT file seems grown more than expected. I'll send you the OTF files (regular is a mere 57KB) so you can experiment with fontsquirrel; just make sure that no subsetting is used to keep all the glyphs. -
Ernesto Baschny commented on patch set 1 08/30/13, 16:43
Thanks, I've got it, and will give it a try soon. About the fonts.css, it was not about "changing the styling", but about adding the definition for the new bold-italic variant which you included in your patch but is not being used yet if I set "Share" and font-weight:bold; font-style:italic. Currently visual/fonts.css contain three definitions, with the new variant a forth should be added too. -
Ernesto Baschny uploaded patch set 2 09/02/13, 15:53
-
Mr. Jenkins commented on patch set 2 09/02/13, 15:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10481/ : SUCCESS -
Ernesto Baschny uploaded patch set 3 09/02/13, 16:25
-
Mr. Jenkins commented on patch set 3 09/02/13, 16:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10482/ : SUCCESS -
Ernesto Baschny voted on patch set 3 V +1 CR +1 09/02/13, 16:26
-
Jigal van Hemert commented on patch set 3 V +2 CR +2 09/02/13, 19:15
Minor changes, RM lets previous votes still count. Ernesto's improvements work for me. -
Jigal van Hemert merged patch set 4 09/02/13, 19:15