Review main Merged

23483[BUGFIX] Backend Layout Grid Wizard not fully visible in Mac Firefox 22

Roland Schenke CR +2 V +2 Easy +1 −1 updated 08/31/13, 21:11

Commit message

Under Firefox the outer table's height and width of the backend layout
wizard is set to 100%. Since there is content before the table, this
leads to the table being cut of, as there are no scrollbars. According
to the suggestion of Philipp Gampe the table's height and width are
changed to 90%.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Kay Strobach +1
  • Verified V +2
    • Philipp Gampe +2
    • Kay Strobach +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 08/30/13, 08:35

  2. Kay Strobach commented on patch set 1 V +1 CR +1 08/30/13, 08:46

    nice one, +1 for the first patch :D perhaps we should consider to make this with css only, but the patch should be ok
  3. Philipp Gampe commented on patch set 1 V +2 CR +2 08/31/13, 16:45

    @Kay do you want to update the patch with a CSS only approach? Otherwise this can be merged.
  4. Kay Strobach commented on patch set 1 08/31/13, 20:14

    I'm fine with the merge - don't make the change more complicated then it is :D
  5. Philipp Gampe merged patch set 2 08/31/13, 21:11

  6. Philipp Gampe commented on patch set 2 08/31/13, 21:11

    Cherry Picked This patchset was cherry picked to change: I589fdfd8de0a8d6ebb4b3ee4fd2a173341116016