Review main Merged

23487[BUGFIX] Incomplete mocking in ext:frontend getImgResourceHook test

Christian Kuhn CR +2 V +2 Easy +11 −2 updated 08/30/13, 12:30

Commit message

A global variable is reset to not call a sub section of the method
under test that may trigger errors.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sascha Egerer +1
  • Verified V +2
    • Christian Kuhn +2
    • Sascha Egerer +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 08/30/13, 12:26

  2. Christian Kuhn uploaded patch set 2 08/30/13, 12:28

  3. Mr. Jenkins commented on patch set 2 08/30/13, 12:29

  4. Sascha Egerer voted on patch set 2 V +1 CR +1 08/30/13, 12:30

  5. Christian Kuhn commented on patch set 2 V +2 CR +2 08/30/13, 12:30

    pretty obvious, merged.
  6. Christian Kuhn merged patch set 3 08/30/13, 12:30