23544[WIP][BUGFIX] Only update fields that are present in DB
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 5
-
Mr. Jenkins commented on patch set 1 09/02/13, 18:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10484/ : SUCCESS -
Sascha Egerer commented on patch set 1 CR -1 09/03/13, 06:15
FileRepository.php:284I would prefer to check against TCA and not against the database table. -
Helmut Hummel commented on patch set 1 09/03/13, 07:56
FileRepository.php:284ReplyI tend agree. This is a copy and paste from ProcessedFilesRepository however and I planned to put this into the AbstractRepository, but ProcessedFiles are not registered in TCA. Should we add TCA for ProcessedFiles, cache the admin_get_fields call or just leave it a direct DB call because update only happens in backend / during indexing and one additional db call would not harm much. -
Sascha Egerer commented on patch set 1 CR +1 10/02/13, 12:15
FileRepository.php:284ReplyHm ok you're right. So keep it like that. What cache would you prefer for admin_get_fields? Anyway... should be handled in an extra patch -
Helmut Hummel abandoned the change 12/23/13, 10:50
not needed any more after recent changes