Review main Abandoned

23623[BUGFIX] Fix useless post-render hook when INT scripts are present

Gabe Blair CR 0 V 0 Easy +4 −2 updated 12/15/14, 20:41

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 09/04/13, 20:04

  2. Zach Davis commented on patch set 1 V +1 CR +1 05/26/14, 19:38

    Would be really nice if someone could review this and merge it in.
  3. Markus Klein commented on patch set 1 05/27/14, 02:19

    Zach, you did not test on 6.2 right? Cause the patch does not apply currently. Moreover I'm a bit worried if moving this hook actually breaks existing usages of the hook.
  4. Zach Davis commented on patch set 1 05/27/14, 02:30

    Yes, I did test and 6.2.3 and yes, now that you mention it, the patch shod be changed slightly for this branch. It is still necessary, however, in 6.2. Moving it may break something, but IMO in its current location, the hook is fairly useless. If there is any chance of getting this revision applied, I will ask Gabe to submit a 6.2 compatible patch. Thanks for your consideration on this. Zach
  5. Markus Klein commented on patch set 1 05/27/14, 09:48

    Well, this is open source, I can guarantee nothing except my own votes.
  6. Markus Klein commented on patch set 1 06/17/14, 23:37

    Still waiting for a new version that applies to master.
    6.0 not supported anymore. 6.3 is the new master branch
  7. Markus Klein updated the commit message in patch set 1 06/19/14, 19:51

  8. Markus Klein commented on patch set 2 CR -1 06/19/14, 19:51

    Still waiting for a new version that applies to master.
  9. Mr. Jenkins commented on patch set 2 06/19/14, 20:12

  10. Anja Leichsenring uploaded patch set 3 12/13/14, 13:59

  11. Anja Leichsenring commented on patch set 3 CR +1 12/13/14, 14:00

    have no usecase to test, so no verified from my side, but code was rebased.
  12. Helmut Hummel commented on patch set 3 CR -1 12/13/14, 14:06

    although I perfectly understand that the post render hook might be in the wrong place, we *cannot* change that in a released version! The hook is like that since 6.0 and if we need to change it, we must mark the change as breaking, thus cannot go into a released branch
  13. Helmut Hummel commented on patch set 3 12/13/14, 14:22

    PageRenderer.php:1962

    we render all css and js libs only to pass them to this hook? that does not seem reasonable to me I agree that the situation is not optimal, as this hook also provides access to things like htmlTag, but the only solution I see is deprecate it and introduce two new hooks (or signals) one for resource manipulation (called late with _INT objects) and HTML code manipulation called in the places proposed here. This also leads to the conclusion that such a change is master only
  14. Markus Klein commented on patch set 3 CR -1 12/14/14, 00:00

    Do not move an existing hook, but create a new signal!
  15. Anja Leichsenring abandoned the change 12/14/14, 08:28

    abandoned for rejected concept. Introducing a signal is the way to go.
  16. Gabe Blair commented on patch set 3 12/15/14, 19:28

    Thanks all; Indeed, perhaps there's another way for us to achieve what we want (without using a hook); I can try to whip up a signal-based approach if someone feels strongly that it's needed at this time. Otherwise, I'm thinking it doesn't make sense for our part to try to make the changes we need in a hook; but rather going back to typoscript might be the best course of action for us here. Thanks again, and sorry for the wild goose chase.
  17. Helmut Hummel commented on patch set 3 12/15/14, 20:41

    @Gabe: It isn't a "wild goose" case and the hook at this place is indeed useless to manipulate other things than the asset list. If you find another hook that fulfills your needs, please let us know. It helps to decide if we should just deprecate usage of other properties than css/js files or introduce a new signal at the place you proposed.