Review main Merged

23669[FEATURE] Enable allWrap.splitChar on all includeJS/includeCSS properties

Christoph Dörfel CR +2 V +2 Normal +108 −36 updated 09/11/13, 14:00

Commit message

The includeJS/includeCSS properties of the PAGE object feature an
allWrap property which replaces all pipe symbols with the generated
tag. This behaviour differs from how wraps are handled in TYPO3.
A splitChar can now be defined for the allWrap property and the wrap
works like the standard wrap method from the ContentObject class.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Issues 1

Files 3

Review log 14

  1. Mr. Jenkins commented on patch set 1 09/07/13, 13:54

  2. Michel Georgy voted on patch set 1 V +1 CR +1 09/09/13, 20:48

  3. Stefan Neufeind voted on patch set 1 CR +1 09/11/13, 12:25

  4. Stefan Neufeind updated the commit message in patch set 1 09/11/13, 12:27

  5. Stefan Neufeind commented on patch set 2 CR +1 09/11/13, 12:28

    Features only go to current master, so I changed Releases-line to 6.2 (thanks Markus)
  6. Mr. Jenkins commented on patch set 2 09/11/13, 12:28

  7. Markus Klein commented on patch set 2 09/11/13, 12:37

    PageRenderer.php:2285

    use ?: operator

    PageRenderer.php:2286

    no trimming here, it was not like this before.
  8. Markus Klein uploaded patch set 3 09/11/13, 12:55

  9. Mr. Jenkins commented on patch set 3 09/11/13, 12:56

  10. Stefan Neufeind uploaded patch set 4 09/11/13, 13:15

  11. Stefan Neufeind commented on patch set 4 V +1 CR +1 09/11/13, 13:15

    adjusted unittests to also check allWrap and the new splitChar
  12. Mr. Jenkins commented on patch set 4 09/11/13, 13:15

  13. Markus Klein voted on patch set 4 V +2 CR +2 09/11/13, 14:00

  14. Markus Klein merged patch set 5 09/11/13, 14:00