Review main Merged

23854[BUGFIX] Locker throws exception if semaphore can not be acquired

Markus Klein CR +2 V +2 Easy +6 −1 updated 01/31/14, 23:03

Commit message

Locker has wrong LockState in semaphore mode, if the lock
could not be acquired.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 09/16/13, 16:00

  2. Markus Klein uploaded patch set 2 09/18/13, 10:14

  3. Mr. Jenkins commented on patch set 2 09/18/13, 10:15

  4. Markus Klein uploaded patch set 3 09/18/13, 11:07

  5. Mr. Jenkins commented on patch set 3 09/18/13, 11:08

  6. Georg Ringer uploaded patch set 4 09/19/13, 06:10

  7. Mr. Jenkins commented on patch set 4 09/19/13, 06:22

  8. Markus Klein rebased onto patch set 4 12/02/13, 11:25

  9. Mr. Jenkins commented on patch set 5 12/02/13, 12:13

  10. Stefan Neufeind voted on patch set 5 CR +1 01/16/14, 23:13

  11. Christian Kuhn voted on patch set 5 CR +1 01/21/14, 19:58

  12. Markus Klein commented on patch set 5 01/23/14, 19:54

    Thanks for your votes here. As this is impossible to test properly - unless modifying your OS to make the acquire fail - I am asking you to merge this directly.
  13. Christian Kuhn voted on patch set 5 V +1 01/31/14, 22:58

  14. Wouter Wolters voted on patch set 5 V +2 CR +2 01/31/14, 23:03

  15. Wouter Wolters merged patch set 6 01/31/14, 23:03