Review main Merged

23902[BUGFIX] Display relations' titles when TCA label field is type inline

Claus Due CR +2 V +2 Easy +1 −0 updated 01/08/14, 11:17

Commit message

This change adds a case to treat "inline" TCA types the same way
"select" is treated when building the record's label value.

Before, if record used field of type "inline" as TCA label field, TYPO3
would display fx "3" (number of related records as stored in field
on parent record).

After, TYPO3 will display fx "Record1, Record2, Record2" if "inline"
field contains three related records named thusly.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benjamin Rau +1
    • Stefan Froemken +1
    • Cedric Ziel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benjamin Rau +1
    • Stefan Froemken +1
    • Cedric Ziel +1

Files 1

Review log 18

  1. Benjamin Rau voted on patch set 1 V +1 CR +1 09/19/13, 11:36

  2. Mr. Jenkins commented on patch set 1 CR -1 V -1 09/19/13, 11:57

  3. Stefan Froemken commented on patch set 1 V +1 CR +1 09/19/13, 12:04

    I'm only a little bit afraid because of all the neg_*-Settings. Inline-Type does not have them. So core has to decide if there could be negative values or not in inline type.
  4. Claus Due commented on patch set 1 09/19/13, 12:07

    @Stefan: Afaik there are no negative values in select either, when foreign_table is used. Which it always will be if the type is "inline". A negative value in this case (as unexected as it would be) would simply cause the SQL query to return no records.
  5. Cedric Ziel commented on patch set 1 V +1 CR +1 09/19/13, 12:20

    Looks good to me. Please let Mr.Jenkins do all of his tasks and rework your commit msg label.
  6. Claus Due uploaded patch set 2 09/19/13, 12:37

  7. Claus Due commented on patch set 2 09/19/13, 12:38

    All those reviews gone, just because the git commit subject changed. Sorry guys :/
  8. Anja Leichsenring commented on patch set 2 09/19/13, 12:39

    no problem, they stay valid. Was only a commit message change.
  9. Benjamin Rau voted on patch set 2 V +1 CR +1 09/19/13, 12:39

  10. Stefan Froemken voted on patch set 2 V +1 CR +1 09/19/13, 12:39

  11. Cedric Ziel voted on patch set 2 V +1 CR +1 09/19/13, 12:40

  12. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/19/13, 12:45

  13. Anja Leichsenring merged patch set 4 09/19/13, 12:45

  14. Mr. Jenkins commented on patch set 2 09/19/13, 13:10

  15. Oliver Hader commented on patch set 4 09/24/13, 07:51

    "select" and "inline" are similar in some cases, but not identical. Currently the patch supports 1n:CSV, 1n:MM, but 1n:FF (foreign_field) is completely missing...
  16. Markus Klein commented on patch set 4 11/11/13, 16:01

    @All: How to proceed with the backports? I'd suggest to merge them and fix the comment of Olly separately
  17. Stefan Neufeind commented on patch set 4 11/14/13, 20:46

    @Olly: How do you propose to fix this? Revert for the moment? Or do you see a solution for a followup then? ...
  18. Benjamin Rau commented on patch set 4 01/08/14, 11:17

    Hey Guys. It was me who showed up the issue and prepared the fix. I actually dont know what is needed to make this fitting the needs. Claus helped with commit because ive not been sure how to commit to gerrit. So i dont want to bother him with it again. Anyone can take over and finish this? I think there is not much to do to close another ticket :) Afterwards we would all be able to use inline fields as label for our records! Not great? :)