24000[TASK] Set X-UA compatibility version to IE=10
Commit message
Review
-
Code review CR +2
- Ernesto Baschny +2
- Henrik Ziegenhain +1
- Aske Ertmann +1
- Jigal van Hemert +1
-
Verified V +2
- Ernesto Baschny +2
- Henrik Ziegenhain +1
- Aske Ertmann +1
Issues 1
Files 1
Review log 11
-
Wouter Wolters commented on patch set 1 CR -1 09/23/13, 20:55
Needs heavy testing by IE users! -
Mr. Jenkins commented on patch set 1 09/23/13, 21:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10893/ : SUCCESS -
Aske Ertmann commented on patch set 1 V +1 CR +1 11/04/13, 11:08
Solves the issue, but whether is has other side effects I can't say -
Mathias Brodala commented on patch set 1 11/04/13, 13:32
See inline comment.DocumentTemplate.php:248How about "Edge"? -
Aske Ertmann commented on patch set 1 11/05/13, 08:22
DocumentTemplate.php:248Replyhmm might be better, then we don't have to change it again.. but I guess there's a reason for this being there in the first place? If we decide to go with this instead it should be "edge" like in html5boilerplate -
Jigal van Hemert commented on patch set 1 CR +1 11/05/13, 11:58
Have to find an IE10 to test, but it is reasonable to upgrade the setting with this release.DocumentTemplate.php:248ReplyEdge seems a good solution, but it is not in just the case where we use this for: edge is only suitable for sites which are regularly checked for browser compatibility. If someone doesn't upgrade the core and uses it with a newer IE, edge would indicate compatibility which isn't there. It's better to test with newer IE versions and upgrade this setting with new releases. Besides, with IE11 the whole compatibility setting is a thing of the past. -
Wouter Wolters voted on patch set 1 CR 0 11/15/13, 11:06
-
Ernesto Baschny commented on patch set 1 V +2 CR +2 11/16/13, 17:38
Tested, works. Backend also works and feels okey. Even Drag&Drop in the file list works this way in IE10. -
Ernesto Baschny merged patch set 2 11/16/13, 17:38
-
Henrik Ziegenhain commented on patch set 1 V +1 CR +1 01/06/19, 11:15
Tested this now for a few days with IE10 and IE8. Didn`t found any negative side effects. -
Henrik Ziegenhain commented on patch set 2 01/06/19, 11:15
This should also be applied to at least ALL supported versions. I think this is bugfix than a feature. What do you think?