Review main Merged

24077[TASK] Remove "Clear language cache" menu item

Christian Kuhn CR +2 V +2 Normal +1 −165 updated 09/26/13, 21:45

Commit message

* To show the item, SYS/lang/cache/clear_menu has to be manually
enabled, and a (not documented) userTSconfig option must be set.
* The item *never* worked since the underlying LanguageCacheClearer
class expects an array with cacheCmd set to either "all" or
"temp_cached", that is not set in the according AJAX call of the
menu action.
* Class LanguageCacheClearer hooks into DataHandler and is only
triggered on clear "all" cache.
* Clearing "all" cache flushes all caches anyway, so the hook
currently triggers flushing the language cache a second time.
* SYS/lang/cache/lifetime is unused and can be removed.

Since the functionality is broken, not documented, obsolete and
"internal" code of ext:lang, the whole thing is removed without
further deprecation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6