Review TYPO3_6-0 Merged 24090[BUGFIX] Check for string before using strlen Markus Klein CR +2 V +2 Normal +85 −2 updated 09/26/13, 22:50 Open in Gerrit Commit message Show more If pi_flexform is converted to an array already, checking via strlen produces a warning. An additional check via is_string suppresses the warning. Resolves: #52091 Resolves: #51684 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I97c41cdedb1afb28e2a9ca39e1d9cfb3921d9f47 Reviewed-on: https://review.typo3.org/24090 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Review Code review CR +2 Christian Kuhn +2 Verified V +2 Christian Kuhn +2 Issues 2 52091Not in Forger, open it in Forge Resolved by this change 51684Not in Forger, open it in Forge Resolved by this change Files 2 typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+9 −2 typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+76 −0 Review log 4 Markus Klein commented on patch set 1 CR -1 09/26/13, 21:43 Unit tests are not correct Markus Klein uploaded patch set 2 09/26/13, 22:11 Christian Kuhn voted on patch set 2 V +2 CR +2 09/26/13, 22:50 Christian Kuhn merged patch set 3 09/26/13, 22:50