Review TYPO3_6-0 Merged

24090[BUGFIX] Check for string before using strlen

Markus Klein CR +2 V +2 Normal +85 −2 updated 09/26/13, 22:50

Commit message

If pi_flexform is converted to an array already, checking via strlen
produces a warning. An additional check via is_string suppresses the
warning.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 2

Files 2

Review log 4

  1. Markus Klein commented on patch set 1 CR -1 09/26/13, 21:43

    Unit tests are not correct
  2. Markus Klein uploaded patch set 2 09/26/13, 22:11

  3. Christian Kuhn voted on patch set 2 V +2 CR +2 09/26/13, 22:50

  4. Christian Kuhn merged patch set 3 09/26/13, 22:50