Review main Merged

24191[TASK] ext:install Break possible redirect loop

Christian Kuhn CR +2 V +2 Normal +55 −0 updated 10/06/13, 19:19

Commit message

The install tool initiates redirects if configuration values were
changed. This is especially done within the "silent upgrade" class.
If something goes wrong there, the system may end up in a redirect
loop and does not show useful debug information.

The patch introduces a simple redirect loop detection and breaks
after ten redirects. This should be enough for the "silent upgrade"
and should be lower than the usual browser based loop detection.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3