Review main Abandoned

24421[TASK] Deny modification of overwritten values in install tool

Sascha Egerer CR 0 V 0 Normal +59 −6 updated 02/01/15, 00:14

Commit message

If you override a setting in the AdditionalConfiguration.php
the value is displayed in the install tool.
If you change the value you get a positive message that it has
been changed. But if you look again in the install tool the
"old" value is displayed again. This is because the install
tool only writes to the LocalConfiguration which is then
overwritten by the AdditionalConfiguration.php.

Add a notice if a value has been changed outside of the
LocalConfiguration and deny modification of this value.

Values that are not part of the DefaultConfiguration are also
not editable and a message is displayed that this setting
is not part of the default TYPO3 configuration.

Testplan:
Set [BE][RTEenabled] to 0 in the install tool.
Add "$GLOBALS['TYPO3_CONF_VARS']['BE']['RTEenabled'] = 1;"
and "$GLOBALS['TYPO3_CONF_VARS']['BE']['invalidValue'] = 1;"
to your AdditionalConfiguration.php.

Result: You should see 2 messages that describe the problem
and changing these values should be permitted.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4