Review main Merged

24596[BUGFIX] DataMapFactory::resolveTableName must remove leading backslashes

Alexander Schnitzler CR +2 V +2 Easy +4 −0 updated 10/11/13, 20:20

Commit message

Currently the method just splits the given class name
by backslashes to detect the proper vendor name. If using
a leading backslash the algorithm of this function causes
a wrong result. Therefore all leading backslashes must be
removed first.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Froemken +1
    • Xavier Perseguers +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Froemken +1
    • Xavier Perseguers +1

Files 2

Review log 13

  1. Alexander Schnitzler uploaded patch set 2 10/11/13, 16:42

  2. Wouter Wolters voted on patch set 2 V +1 CR +1 10/11/13, 17:28

  3. Xavier Perseguers commented on patch set 2 CR -1 10/11/13, 18:08

    DataMapFactory.php:163

    ltrim() to fit the bug description and because a class name will never end with a backslash

    DataMapFactoryTest.php:416

    first \ should be escaped
  4. Xavier Perseguers uploaded patch set 3 10/11/13, 18:08

  5. Xavier Perseguers voted on patch set 3 V +1 CR +1 10/11/13, 18:08

  6. Mr. Jenkins commented on patch set 1 10/11/13, 18:30

  7. Stefan Froemken voted on patch set 3 V +1 CR +1 10/11/13, 18:36

  8. Alexander Schnitzler commented on patch set 3 10/11/13, 18:36

    Thanks, Xavier!
  9. Mr. Jenkins commented on patch set 2 10/11/13, 18:41

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/11/13, 19:14

  11. Anja Leichsenring merged patch set 4 10/11/13, 19:14

  12. Anja Leichsenring commented on patch set 4 10/11/13, 19:15

    Cherry Picked This patchset was cherry picked to change: Icdc46facf66260bf528994964fb713d3dd24b3c6
  13. Mr. Jenkins commented on patch set 3 10/11/13, 20:20