Review main Merged

24623[BUGFIX] Clean-up responsibilities of FAL classes

Steffen Ritter CR +2 V +2 Normal +112 −116 updated 10/12/13, 17:04

Commit message

This is a followup for the patch
I6ceeb8db4dd4e470e7c72dcfbc2121093411da75.

The latest change sets missed to adapt
the unit-tests accordingly.

Furthermore due to this change it came to light,
that the active loading option of storages in the file object
may create a recursion issue, if the file is not indexed.
This architectural problem has been removed by making
the constructor argument mandatory and extend the
ResourceFactory to always inject the correct storage.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13