Review main Merged

24628[BUGFIX] Fix incomplete mocking in DataMapFactoryTest

Alexander Schnitzler CR +2 V +2 Easy +5 −5 updated 10/12/13, 21:45

Commit message

Using "expects" on $mockDataMapFactory may fail with
several methods like "setOneToOneRelation" as these methods
return a ColumnMap object but the mock doesn't.

This patch adds the missing "->will($this->return())"
for these methods.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 10/12/13, 14:03

  2. Christian Kuhn commented on patch set 1 V +2 CR +2 10/12/13, 21:45

    This is obvious by reading the tests.
  3. Christian Kuhn merged patch set 2 10/12/13, 21:45