Review main Merged

24940[BUGFIX] Check for query failures in admin methods

Thomas Maroschik CR +2 V +2 Easy +10 −6 updated 10/21/13, 18:08

Commit message

In the DatabaseConnection class the two methods admin_get_fields
 and admin_get_keys throw a fatal error when a query failure occurs.

 This fix introduces two checks that prevent the methods from fataling
 and return an empty result on failure.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 10/21/13, 17:29

  2. Jigal van Hemert commented on patch set 1 V +2 CR +2 10/21/13, 18:08

    Merged as no-brainer. Before iterating the result it must be checked that the result can be iterated at all.
  3. Jigal van Hemert merged patch set 2 10/21/13, 18:08