Review main Merged

2503[BUGFIX] Do not suppress parse errors in ext_emconf.php files

Steffen Gebert CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

In case of parse errors in an ext_emconf.php file, the error message
has been suppressed because of an @include(). Nevertheless, the EM
stops working with a blank page (without any error log entry).

Removing the @ shows the warning so that it easier for the user to
identify the erroneous extension.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Georg Ringer +1
    • Steffen Kamper +1
  • Verified V +2
    • Steffen Gebert +2
    • Georg Ringer +1
    • Steffen Kamper +1

Issues 1

Files 1

Review log 7

  1. Steffen Kamper commented on patch set 2 06/03/11, 07:05

    Verified; Looks good to me, but someone else must approve
  2. Georg Ringer commented on patch set 2 06/03/11, 07:05

    Verified; Looks good to me, but someone else must approve IMO a nobrainer
  3. Steffen Gebert commented on patch set 2 V 0 06/03/11, 07:05

    by team member; Looks good to me, approved
  4. Steffen Gebert uploaded patch set 2 06/03/11, 07:05

  5. Mr. Jenkins commented on patch set 1 06/03/11, 07:05

  6. Mr. Jenkins commented on patch set 2 06/03/11, 07:05

  7. Steffen Gebert merged patch set 2 06/03/11, 07:05