Review TYPO3_4-5 Merged

25157[BUGFIX] Remove declare(encoding=)

Josef Glatz CR +2 V +2 Easy +0 −1 updated 01/09/19, 20:56

Commit message

AbstractWidgetViewHelper can throw warnings about invalid
declare statements if zend.multibyte is off. Those lines
were also dropped in TYPO3.Fluid, TYPO3 6.0 & TYPO3 4.7.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • Wouter Wolters +1
    • Ernesto Baschny +1
  • Verified V +2
    • Marc Bastian Heinrichs +2

Issues 1

Files 1

Review log 5

  1. Ernesto Baschny commented on patch set 1 CR +1 01/09/19, 20:56

    yes, go for it!
  2. Marc Bastian Heinrichs voted on patch set 1 CR +1 01/09/19, 20:56

  3. Marc Bastian Heinrichs voted on patch set 1 V +2 CR +2 01/09/19, 20:56

  4. Wouter Wolters voted on patch set 1 CR +1 01/09/19, 20:56

  5. Marc Bastian Heinrichs merged patch set 2 01/09/19, 20:56