Review main Merged

2531[BUGFIX] Use runtime cache in tslib_fe::get_cache_timeout

Steffen Gebert CR +2 V +2 Easy +9 −6 updated 06/03/13, 20:49

Commit message

Thanks to #20473, start and stop times of records are now taken into
account during a page's cache lifetime calculation.
To prevent repeated computations, the value is cached inside
tslib_fe::get_cache_timeout(), using a class variable
getCacheTimeoutCache.

The Runtime Cache (#27208) not only offers a cleaner way to do so, it
also provides a remedy against the currently existing problem that
get_cache_timeout() does its job exactly twice: Once during menu
generation (which seems to work with a cloned copy of TSFE) and once
before putting the page contents into the cache. As both class instances
share the runtime cache, the second calculation can be safed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1