Review main Merged

25382[TASK] CleanUp canonicalizing identifiers in FAL-drivers

Steffen Ritter CR +2 V +2 Normal +52 −51 updated 11/21/13, 09:35

Commit message

In https://review.typo3.org/23398 the possibility was
created, to use case-sensitive fileIdentifiers in
database collations which are not case sensitive. To
do so a new sanitiation of file-identifiers has been
introduced into the drivers.

During the patch-sets a new function has been created
while there would have been already some functions
perfectly fitting that task.

Introducing this new functionality in the old ones
showed, that these are used for non-identifier
path (absolute external), too which created problems.
Therefore this has been split out.

Finally the getAbsolutePath and variants manually
concatenating the basePath have been revised, and
duplicate calls to the canonicalize functions have
been removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3