Review main Merged

25553[BUGFIX] Fix moving/copying files and folders between storages

Frans Saris CR +2 V +2 Easy +4 −4 updated 11/21/13, 16:07

Commit message

When a file or folder is moved between 2 storages the target
storages is asked for the filepermissions of the source
file/folder. This breaks because current storages + driver
can not access/find source.

This patch makes sure that on places where a source can be
from an other storage the source storage is used for the
permission check.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Fabien Udriot +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 7

  1. Frans Saris commented on patch set 1 11/20/13, 22:27

    See http://forge.typo3.org/issues/53802#note-3 for easy test instructions.
  2. Mr. Jenkins commented on patch set 1 11/20/13, 22:38

  3. Fabien Udriot voted on patch set 1 CR +1 11/21/13, 14:25

  4. Alexander Opitz voted on patch set 1 V +1 CR +1 11/21/13, 16:01

  5. Markus Klein commented on patch set 1 V +2 CR +2 11/21/13, 16:07

    very nice!!
  6. Markus Klein merged patch set 2 11/21/13, 16:07

  7. Markus Klein commented on patch set 2 11/21/13, 16:07

    Cherry Picked This patchset was cherry picked to change: Ib2c1443fad295a3b7eeeb01ab38359fcdf6849ab