Review main Merged

25715[TASK] Simplify returns in ConfigurationManager

Michiel Roos CR +2 V +2 Easy +4 −15 updated 11/29/13, 17:20

Commit message

writeLocalConfiguration() and writeAdditionalConfiguration()
have return statements like:
return $result === FALSE ? FALSE : TRUE;

This can be reduced to:
return $result;

Moreover the return value of canWriteConfiguration()
can be optimized as well.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1