Review main Merged

2620[BUGFIX] Prevent duplicate stdWrap for media content

Alexander Stehlik CR +2 V +2 Easy +5 −6 updated 06/03/13, 20:49

Commit message

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Files 1

Review log 15

  1. Jigal van Hemert merged patch set 1 10/07/11, 13:03

  2. Stefan Neufeind commented on patch set 1 10/07/11, 13:03

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 1 10/07/11, 13:03

    Steffen, note that a bracket was moved ...
  4. Stefan Neufeind commented on patch set 1 10/07/11, 13:03

    @Steffen: Please review your objection.
  5. Steffen Ritter commented on patch set 1 10/07/11, 13:03

    I would prefer that you didn't submit this as far as I see, you just added a comment... This to mee does not go inline with your commit-comment. could you kindly elaborate a bit on this.
  6. Kay Strobach commented on patch set 1 10/07/11, 13:03

    Verified; Looks good to me, but someone else must approve
  7. Jigal van Hemert commented on patch set 1 10/07/11, 13:03

    Tested it manually and I can give my votes as core member. If someone pushes a new version which applies to current master I'll merge it.
  8. Jigal van Hemert uploaded patch set 3 10/07/11, 13:03

  9. Jigal van Hemert commented on patch set 3 V 0 10/07/11, 13:03

    by team member; Looks good to me, approved Has enough votes. Removed comments and improved commit message.
  10. Alexander Stehlik commented on patch set 2 10/07/11, 13:03

    Hi Jigal, thanks for reviewing! I uploaded a new patch for the current master. The code didn't change.
  11. Alexander Stehlik uploaded patch set 2 10/07/11, 13:03

  12. Jo Hasenau commented on patch set 1 10/07/11, 13:03

    Verified; Looks good to me, but someone else must approve
  13. Mr. Jenkins commented on patch set 1 10/07/11, 13:03

  14. Mr. Jenkins commented on patch set 2 10/07/11, 13:03

  15. Mr. Jenkins commented on patch set 3 10/07/11, 13:03