Review main Abandoned

26574[TASK] Remove a rather large number of hook calls and iterations

Claus Due CR 0 V 0 Normal +1 −223 updated 06/11/14, 11:37

Commit message

This task removes hooks from the following places:

* Inline field controls for some exotic use cases, rendered
  multiple times per record which is being edited.
* FormEngine "getFieldClass" which serves EXT:dynaflex alone,
  should be replaced with a class override that triggers only
  when their extension is installed, rather than slow down
  every single form field being rendered in TYPO3 to serve
  one TER extension.
* BackendUtility "viewOnClickClass" which also is repeatedly
  called for every record being listed and serves much the
  same purpose and poses the same problem as the FormEngine
  hooks do: slows down everything to support tiny things.
* PageRepository "getPage" hooks. Filtering is possible in
  many ways but the least friendly is a hook that gets
  called for every page that gets fetched (including all
  pages that are shown in menus).
* Last but not least: hooks in DatabaseConnection which are
  iterated, checked, called and have parameter copy arrays
  built on every single SELECT, UPDATE, INSERT etc. query
  have been removed. About 3/4 of these hooks are better
  made in a DataHandler hook which only slows down TYPO3
  when you actually edit the record. The last 1/4 is, among
  others, the very invasive hook that listens to every
  SELECT query that's performed. Every query, every request.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5