Review main Merged

26677[BUGFIX] Repository uses wrong property to calc current result page

Benjamin Rau CR +2 V +2 Easy +1 −1 updated 01/07/14, 17:59

Commit message

In the IndexedSearchRepository on line 157 an undefined/unused 
property $this->resultsPerPage is used for the calculation 
of the current page the visitor is showing on search results.

Instead of using $this->resultsPerPage we have to use 
$this->numberOfResults which is defined and contains the expected setting.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 7

  1. Benjamin Rau updated the commit message in patch set 1 01/07/14, 17:35

  2. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/07/14, 17:41

  3. Mr. Jenkins commented on patch set 1 CR -1 V -1 01/07/14, 17:47

  4. Mr. Jenkins commented on patch set 2 01/07/14, 17:58

  5. Markus Klein voted on patch set 2 V +2 CR +2 01/07/14, 17:59

  6. Markus Klein merged patch set 3 01/07/14, 17:59

  7. Markus Klein commented on patch set 3 01/07/14, 17:59

    Cherry Picked This patchset was cherry picked to change: I37c3a08c1049eb6166704b2b98ba071f03aad243