Review main Merged

26692[BUGFIX] Check default salting method first

Christoph Dörfel CR +2 V +2 Normal +53 −27 updated 03/27/14, 10:22

Commit message

Prioritise default salting hashing method when determining
the salting hashing method of a given salted hash.

Fixes rare cases when the method "isValidSaltedPW()" returns TRUE
for similar salting implementations.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • Jigal van Hemert +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 30

Show 5 earlier messages
  1. Mr. Jenkins commented on patch set 1 01/08/14, 13:29

  2. Wouter Wolters voted on patch set 1 CR +1 02/03/14, 17:32

  3. Wouter Wolters commented on patch set 1 02/24/14, 21:49

    *ping*
  4. Markus Klein voted on patch set 1 CR +1 02/24/14, 22:22

  5. Markus Klein commented on patch set 1 CR 0 03/06/14, 21:36

    SaltFactory.php:119

    this is not consistent. getRegisteredSaltedHashingMethods() returns an array like array( classname => classname)
  1. Markus Klein commented on patch set 1 CR -1 03/06/14, 22:00

    This whole area is not very consistent. I'll improve that.
  2. Markus Klein uploaded patch set 2 03/06/14, 22:53

  3. Markus Klein uploaded patch set 3 03/06/14, 22:54

  4. Wouter Wolters commented on patch set 3 CR +1 03/06/14, 22:59

    SaltFactory.php:99

    !== NULL
  5. Mr. Jenkins commented on patch set 2 03/06/14, 23:13

  6. Mr. Jenkins commented on patch set 3 03/06/14, 23:22

  7. Nicole Hummel commented on patch set 3 CR -1 03/07/14, 21:46

    SaltFactory.php:60

    How could you iterate over $configMethods if it isn't an array? This should throw at least some warnings

    SaltFactory.php:99 Reply

    is_null() equals $saltedHash === NULL which is more common in core

    SaltFactory.php:124

    Why was the $mode parameter added?

    ExtensionManagerConfigurationUtility.php:155

    "superchallenged" isn't used anymore so this is always true and can be removed,

    ExtensionManagerConfigurationUtility.php:238

    $instance === NULL
  8. Markus Klein commented on patch set 3 03/08/14, 09:54

    Will push an update

    SaltFactory.php:60 Reply

    that is of course wrong.

    SaltFactory.php:99 Reply

    will fix

    SaltFactory.php:124 Reply

    It's used in line 126.
  9. Markus Klein commented on patch set 3 03/08/14, 09:55

    ExtensionManagerConfigurationUtility.php:155 Reply

    will do that

    ExtensionManagerConfigurationUtility.php:238 Reply

    Doesn't make a difference, but will change.
  10. Markus Klein uploaded patch set 4 03/08/14, 10:01

  11. Markus Klein commented on patch set 4 03/08/14, 10:02

    @Nicole: Superchallenged is still the (hardcoded) default, if no rsa is available. So I didn't change that.
  12. Mr. Jenkins commented on patch set 4 03/08/14, 10:14

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 03/08/14, 16:48

  14. Jigal van Hemert commented on patch set 4 CR +1 03/09/14, 11:12

    How can it be tested?
  15. Stefan Neufeind voted on patch set 4 CR +1 03/09/14, 17:35

  16. Nicole Hummel commented on patch set 4 03/09/14, 19:14

    @Markus: superchallenged isn't supported anymore as the whole backend uses saltedpasswords which wouldn't work with superchallenged passwords anymore!
  17. Markus Klein commented on patch set 4 03/10/14, 11:37

    Then we should remove everything around superchallanged completely please. If everybody agrees I'll push a new changeset to clean this up.
  18. Nicole Hummel commented on patch set 4 03/10/14, 11:48

    @Markus: IMHO this is not as simple as it sounds as superchallenged implementation is mixed with BE and FE. But it has to stay for FE usage.
  19. Markus Klein commented on patch set 4 03/26/14, 22:41

    ping. one v+1 missing
  20. Stefan Neufeind voted on patch set 4 V +2 CR +2 03/26/14, 23:39

  21. Stefan Neufeind merged patch set 5 03/26/14, 23:39

  22. Oliver Klee commented on patch set 5 03/27/14, 10:10

    Shouldn't this be "7.0" now (or "7.0, 6.2")?
  23. Stefan Neufeind commented on patch set 5 03/27/14, 10:12

    Reply

    master is still 6.2 at the moment, so we don't yet need to cherry-pick this somewhere else or so
  24. Oliver Klee commented on patch set 5 03/27/14, 10:19

    Reply

    Ah, okay, I didn't know that. Thanks for the explanation. (I incorrectly assumed that directly after (or before) a major release, a corresponding branch gets created so that we can put new features in without affecting the next bug-fix release.)
  25. Stefan Neufeind commented on patch set 5 03/27/14, 10:22

    Reply

    Ernesto said we'll postpone that a week or two, so we don't have to "backport" all bugfixes that might arise now. :-) For fixes the situation is okay. The only thing we can't do yet is merge new large changes or features - but that should be possible to delay some more days.