Review main Merged

27089[BUGFIX] Wrong usage of intExplode in getTreeList

Stefan Froemken CR +2 V +2 Easy +4 −2 updated 02/25/14, 23:10

Commit message

getTreeList calls intExplode which converts empty
arrays to 0. This patch removes empty arrays
within intExplode.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 37

Show 12 earlier messages
  1. Mr. Jenkins commented on patch set 1 01/28/14, 11:04

  2. Markus Klein updated the commit message in patch set 1 01/28/14, 13:14

  3. Mr. Jenkins commented on patch set 2 01/28/14, 13:28

  4. Markus Klein commented on patch set 2 01/28/14, 13:30

    Please fix the other bug as well. We do not have a single unit test for this function, so I'm really unsure if this change will break other places where this function is used.

    ContentObjectRenderer.php:7425

    This is another bug. getTreeList is NOT static.
  5. Benni Mack uploaded patch set 3 01/28/14, 18:54

  6. Benni Mack commented on patch set 3 CR +1 01/28/14, 18:55

    Fixed mentioned non-static method call as well.
  7. Mr. Jenkins commented on patch set 3 01/28/14, 19:09

  8. Markus Klein commented on patch set 3 CR +1 01/28/14, 19:17

    As I said. I don't know what consequences this might have to all other places where this method is used.
  9. Xavier Perseguers voted on patch set 3 CR +1 01/29/14, 08:15

  10. Wouter Wolters voted on patch set 3 CR +1 01/29/14, 18:36

  11. Benni Mack commented on patch set 3 01/30/14, 14:22

    @markus: If you have a look at the usages, you'll see that AbstractMenuContetnObject calls it in a static environment. we should not change that to the non-static version.
  12. Benni Mack uploaded patch set 4 01/30/14, 14:22

  1. Benni Mack uploaded patch set 5 01/30/14, 14:26

  2. Benni Mack commented on patch set 5 01/30/14, 14:27

    I fixed the places in the core where the method is called statically, which should do the trick. HOWEVER, I want to remind you that this should normally be done in a separate issue - fixing the call context to a method. Please do this separately in the future, Markus.
  3. Mr. Jenkins commented on patch set 5 01/30/14, 19:17

  4. Markus Klein commented on patch set 5 CR +1 01/30/14, 21:08

    Thanks Benni. Of course I'd have made it a separate issue, if I recognized that all calls to this method were plain bullshit. I thought it was only forgotten to change that in this single place.
  5. Markus Klein voted on patch set 5 V +1 02/17/14, 15:14

  6. Markus Klein uploaded patch set 6 02/17/14, 15:16

  7. Markus Klein commented on patch set 6 V +1 CR +1 02/17/14, 15:17

    rebased
  8. Mr. Jenkins commented on patch set 6 02/17/14, 22:46

  9. Stefan Neufeind commented on patch set 6 V -1 CR +1 02/17/14, 23:29

    In general the patch works as expected. In Tests like getTreeListReturnsChildPageUids() I however only get one "0", not more - elso if I increase the recursion-level. Do you know why? With this patch two unittests getTreeList* fail, since they still have a "0," in their expected list. Do we agree that having the zero there is "just wrong" since it's no PID anyhow? If so, do we also fix this in (at least) 6.1?
  10. Markus Klein commented on patch set 6 V 0 02/18/14, 08:00

    Argh... I didn't run the unit tests yet. Yes the unit tests need to be adapted of course and a backport to 6.1 would be fine too for me.
  11. Dmitry Dulepov commented on patch set 6 V -1 02/18/14, 08:37

    Incompatible change of a stable API :(
  12. Stefan Neufeind commented on patch set 6 02/18/14, 08:44

    Yes, I had the same worries about "changing a stable API", well "changing behaviour for a relased version". How about we only change that for 6.2? I don't think the change is too big after all, but maybe we're causing trouble for people on 6.1 otherwise.
  13. Markus Klein commented on patch set 6 CR -2 02/18/14, 08:58

    Ok since this is a never ending story here, I'll move the no-brainer fix for the static calls to a separate ticket now.
  14. Markus Klein uploaded patch set 7 02/18/14, 09:17

  15. Markus Klein voted on patch set 7 CR +1 02/18/14, 09:18

  16. Mr. Jenkins commented on patch set 7 02/18/14, 09:43

  17. Dmitry Dulepov voted on patch set 7 CR +2 02/25/14, 13:18

  18. Benni Mack voted on patch set 7 V +1 02/25/14, 13:24

  19. Markus Klein uploaded patch set 8 02/25/14, 15:49

  20. Markus Klein commented on patch set 8 CR +1 02/25/14, 15:50

    needed a rebase.
  21. Benni Mack voted on patch set 8 V +1 CR +1 02/25/14, 21:37

  22. Markus Klein voted on patch set 8 V +1 02/25/14, 22:11

  23. Benni Mack voted on patch set 8 V +2 CR +2 02/25/14, 22:21

  24. Benni Mack merged patch set 9 02/25/14, 22:21

  25. Stefan Neufeind commented on patch set 9 02/25/14, 23:10