27107[TASK] Increase title column width in Web List module
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Ernesto Baschny +1
-
Verified V +2
- Christian Kuhn +2
- Ernesto Baschny +1
Issues 1
Files 1
Review log 13
-
Wouter Wolters updated the commit message in patch set 1 01/28/14, 22:05
-
Mr. Jenkins commented on patch set 1 01/28/14, 22:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13290/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/28/14, 22:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13292/ : SUCCESS -
Ernesto Baschny uploaded patch set 3 01/29/14, 09:05
-
Ernesto Baschny commented on patch set 3 V +1 CR +1 01/29/14, 09:06
Good catch. Reason for this is the increased font-size (12px instead of 11px), which is why this now happens where it didn't happen before. 350px should be enough thou, proportionally to the font size increase. -
Mr. Jenkins commented on patch set 3 01/29/14, 09:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13300/ : SUCCESS -
Marcin Sągol commented on patch set 3 01/29/14, 11:44
I have few records now (after change to 350px) that take 2 lines. I think 360px or 370px should be enough. -
Marcin Sągol commented on patch set 3 01/29/14, 12:15
Just tested it on a list with 300 records and second one with 100 records. The safe value is 380 px for me (tested on Kubuntu so the font rendering might be a little bit different than on Windows but not that much). -
Christian Kuhn voted on patch set 3 V +2 CR +2 01/29/14, 19:42
-
Christian Kuhn merged patch set 4 01/29/14, 19:42
-
Marcin Sągol commented on patch set 4 01/29/14, 19:49
Hmm i think the size should be increased bit more as sugested in previous comments. -
Ernesto Baschny commented on patch set 4 01/30/14, 16:07
could you share some screenshots please, Marcin? -
Marcin Sągol commented on patch set 4 01/30/14, 17:06
Ernesto 350px width works in Firefox but not in Chrome/Chromium. The calculated width of this table cell is not the same in this browsers.