Review main Merged

27197[TASK] Skip GeneralUtility::resolveBackPath() if its not necessary

Andreas Wolf CR +2 V +2 Easy +3 −0 updated 01/31/14, 16:43

Commit message

resolveBackPath() is run a couple hundred times per script run,
especially in the backend. As this method is only really necessary in a
few special cases (when a path really contains "../"), we can skip it
for all other paths with an early return.

The check is really weak (it will not skip the call for things like
"/some/dir..with..dots..inbetween/"), but this is ok because we just use
it to skip all *really* obvious cases while at best not missing *any*
legitimate use-case, which should be achieved with this commit.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1