Review main Merged

27255[TASK] Improve revExplode performance

Andreas Wolf CR +2 V +2 Easy +11 −3 updated 02/28/14, 01:25

Commit message

``GeneralUtility::revExplode()`` is implemented in a very
performance-intensive way: it always does a complete cycle with multiple
array operations, be it necessary or not.

To make the method more performant, it is split into different cases.
Currently, the only used value for the ``$count`` in the core is 2, but
we have to implement all others, too, of course. The performance
increase for $count=2 is greater than 50%; the others will at maximum be
as bad as the old implementation, plus a very tiny overhead for checking
the value of ``$count``.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2