Review main Merged

27302[BUGFIX] Check folder access for inline uploader

Alexander Stehlik CR +2 V +2 Easy +23 −16 updated 02/05/14, 08:57

Commit message

Before the inline drag and drop upload functionality to the default
upload folder is enabled it is made sure that the upload folder
is initialized and that the user is allowed to add files.

Review

  • Code review CR +2
    • Markus Klein +2
    • Lorenz Ulrich +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Lorenz Ulrich +1

Issues 1

Files 1

Review log 18

  1. Alexander Stehlik uploaded patch set 2 02/03/14, 15:30

  2. Alexander Stehlik commented on patch set 2 02/03/14, 15:30

    Small performance improvement, CGL fixes
  3. Lorenz Ulrich commented on patch set 2 V +1 CR +1 02/03/14, 15:58

    Thanks!
  4. Markus Klein commented on patch set 2 02/03/14, 17:00

    InlineElement.php:908

    no need for the extra ()
  5. Mr. Jenkins commented on patch set 1 02/03/14, 17:35

  6. Mr. Jenkins commented on patch set 2 02/03/14, 17:49

  7. Alexander Stehlik uploaded patch set 3 02/03/14, 18:57

  8. Alexander Stehlik commented on patch set 3 02/03/14, 18:58

    Only removed superfluous brackets in condition. No functional changes.
  9. Markus Klein voted on patch set 3 CR +1 02/03/14, 19:28

  10. Lorenz Ulrich commented on patch set 3 V +1 CR +1 02/03/14, 19:30

    Tested.
  11. Markus Klein uploaded patch set 4 02/03/14, 19:35

  12. Markus Klein commented on patch set 4 CR +1 02/03/14, 19:36

    Only cosmetic changes.
  13. Mr. Jenkins commented on patch set 3 02/03/14, 20:38

  14. Mr. Jenkins commented on patch set 4 02/03/14, 20:51

  15. Lorenz Ulrich voted on patch set 4 V +1 CR +1 02/04/14, 19:55

  16. Wouter Wolters voted on patch set 4 CR +1 02/04/14, 20:18

  17. Markus Klein voted on patch set 4 V +2 CR +2 02/05/14, 08:57

  18. Markus Klein merged patch set 5 02/05/14, 08:57