27420[TASK] Centralize DB queries
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Oliver Klee +1
- Pascal Dürsteler +1
-
Verified V +2
- Christian Kuhn +2
- Pascal Dürsteler +1
Issues 1
Files 1
Review log 11
-
Mr. Jenkins commented on patch set 1 02/07/14, 16:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13795/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13794/ : SUCCESS -
Stefan Neufeind commented on patch set 1 CR +1 02/08/14, 10:07
Just one nitpick. Besides that I like the idea. I expect the queryies itself are so "expensive" that the additional function-call "won't really matter"?DatabaseConnection.php:201remove isConnected here as well then -
Markus Klein commented on patch set 1 02/08/14, 13:17
@Stefan: The function call itself is very negligible.DatabaseConnection.php:460Why the $resultMode parameter if it is not used at all? -
Andreas Wolf commented on patch set 1 02/08/14, 14:15
DatabaseConnection.php:460ReplyCould be removed, agreed. I just used an automated refactoring in PhpStorm which always takes all parameters. -
Stefan Neufeind uploaded patch set 2 02/09/14, 18:38
-
Stefan Neufeind commented on patch set 2 CR +1 02/09/14, 18:38
removed $resultMode and various isConnected -
Pascal Dürsteler voted on patch set 2 V +1 CR +1 02/09/14, 18:44
-
Mr. Jenkins commented on patch set 2 02/09/14, 19:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13909/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13908/ : SUCCESS -
Oliver Klee voted on patch set 2 CR +1 02/09/14, 19:22
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/10/14, 12:44
-
Christian Kuhn merged patch set 3 02/10/14, 12:44