Review main Merged

27533[TASK] Initialize FormProtectionFactory later in alt_doc.php

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 02/11/14, 21:52

Commit message

The FormProtectionFactory can be initialized later.
Move the initialization to the point where it is needed.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 02/10/14, 23:07

  2. Markus Klein commented on patch set 1 V +1 CR +1 02/10/14, 23:17

    looks like a real no-brainer
  3. Oliver Klee commented on patch set 1 02/10/14, 23:43

    ald -> alt
  4. Wouter Wolters updated the commit message in patch set 1 02/11/14, 07:34

  5. Mr. Jenkins commented on patch set 2 02/11/14, 07:52

  6. Benni Mack voted on patch set 2 CR +1 02/11/14, 08:56

  7. Helmut Hummel voted on patch set 2 V +2 CR +2 02/11/14, 21:52

  8. Helmut Hummel merged patch set 3 02/11/14, 21:52