27642[TASK] Backport Flow JsonView
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 2
Review log 13
-
Mr. Jenkins commented on patch set 1 02/16/14, 14:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14080/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/14079/ : SUCCESS -
Xavier Perseguers commented on patch set 1 03/17/14, 17:03
I feel like we need some unit/functional tests to make sure it is usable -
Jan Kiesewetter commented on patch set 1 03/18/14, 09:04
We could backport the test as well https://git.typo3.org/Packages/TYPO3.Flow.git/blob/HEAD:/Tests/Unit/Mvc/View/JsonViewTest.php Haven't seen it. -
Stefan Neufeind commented on patch set 1 03/18/14, 10:04
@Jan: please port that test and push a new revision -
Jan Kiesewetter uploaded patch set 2 03/18/14, 11:16
-
Mr. Jenkins commented on patch set 2 03/18/14, 11:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15259/ : SUCCESS -
Cedric Ziel voted on patch set 2 CR +1 03/18/14, 14:28
-
Stefan Froemken voted on patch set 2 V +1 CR +1 03/19/14, 10:36
-
Cedric Ziel voted on patch set 2 V +1 03/19/14, 12:27
-
Stefan Neufeind uploaded patch set 3 03/21/14, 22:25
-
Stefan Neufeind commented on patch set 3 V +2 CR +2 03/21/14, 22:26
Adjusted copyright-notice to match other classes in Extbase (Flow-backports). Tests work fine. Votes from StefanF/Cedric still valid (+1/+1 each). -
Stefan Neufeind merged patch set 4 03/21/14, 22:26
-
Mr. Jenkins commented on patch set 3 03/21/14, 22:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/15492/ : SUCCESS