Review main Abandoned

27644[TASK] try isset($array[$key]) before array_key_exists())

Michiel Roos CR 0 V 0 Normal +126 −90 updated 03/14/15, 14:02

Commit message

Calling array_key_exists can be avoided most of the time by using isset().

isset() may however return FALSE for cases where there is in fact an
existing key, but where the value is NULL. So we need to OR the isset()
with the old array_key_exists to have a fallback in place for the cases
where the array value is a NULL.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 61

Show 41 more files