27850[BUGFIX] Don't modify variables in tree view
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 1
Review log 8
-
Wouter Wolters commented on patch set 1 V +1 CR +1 02/25/14, 20:10
Fixes it for me -
Markus Klein voted on patch set 1 CR +1 02/25/14, 20:12
-
Markus Klein commented on patch set 1 CR -1 02/25/14, 20:31
Will investigate why the second level does not work -
Markus Klein commented on patch set 1 V -1 02/25/14, 21:54
Got the problem: The loop in the tree() function is foreach ($arr as $key => $value) { ... In the second recursion $arr is of type LoadedExtensionArrayElement, which does not implement \Iterator interface. Therefore PHP iterates over the properties of the class and these are $package $extensionFilesToCheckFor $extensionInformation This is the output we see in the BE, but prefixed with (null byte)*(null byte) This is a) wrong b) killing all links c) killing xdebug Hallelujah! -
Markus Klein uploaded patch set 2 02/25/14, 22:00
-
Markus Klein voted on patch set 2 V +1 CR +1 02/25/14, 22:01
-
Wouter Wolters voted on patch set 2 V +2 CR +2 02/25/14, 22:06
-
Wouter Wolters merged patch set 3 02/25/14, 22:06