Review main Merged

2788[BUGFIX] Add admin-note to tab-description of extension-manager

Stefan Neufeind CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

All other admin-modules already have this under "About modules".

Review

  • Code review CR +2
    • Susi Moog +2
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 12

  1. Mario Rimann commented on patch set 1 08/21/11, 15:01

    I would prefer that you didn't submit this Please provide an updated patch with changes in the XLIFF file.
  2. Stefan Neufeind commented on patch set 1 08/21/11, 15:01

    will also need updates to l10n-files and their (lately added) xliff-variants, sorry :-)
  3. Susi Moog uploaded patch set 2 08/21/11, 15:01

  4. Susi Moog commented on patch set 2 08/21/11, 15:01

    Verified; Looks good to me, but someone else must approve Here is the xlf version.
  5. Susi Moog commented on patch set 2 V 0 08/21/11, 15:01

    by team member; Looks good to me, approved
  6. Steffen Gebert commented on patch set 1 08/21/11, 15:01

    I would prefer that you didn't submit this As XLIFF is coming, I suggest to wait a few days, until it is completely integrated. Currently, we must not change labels, but introduce new ones instead.
    Please use Resolves:
  7. Chris topher commented on patch set 1 08/21/11, 15:01

    Hi Stefan, what abot that one? XLIFF is in and you can use labels in XLIFF files now.
  8. Chris topher commented on patch set 1 08/21/11, 15:01

    Verified; Looks good to me, but someone else must approve Exactly what I mean. Thanks for pushing this one!
  9. Philipp Gampe commented on patch set 2 08/21/11, 15:01

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 08/21/11, 15:01

  11. Mr. Jenkins commented on patch set 2 08/21/11, 15:01

  12. Susi Moog merged patch set 2 08/21/11, 15:01