Review main Merged

2790[BUGFIX] Adjust shortcut mode labels for selected/current page

Stefan Neufeind CR +2 V +2 Easy +3 −3 updated 06/03/13, 20:49

Commit message

If a certain page is selected then shortcut mode refers to that page.
Only otherwise the current page is the point of reference for
first/random/parent.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Oliver Hader +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Oliver Hader +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 28

Show 3 earlier messages
  1. Stefan Neufeind commented on patch set 1 12/21/11, 20:24

    will need to update other translations (and the newly created xliff-files) as well. Also applies to TYPO3 4.5 (same shortcut mode-functionality).
  2. Steffen Gebert commented on patch set 1 12/21/11, 20:24

    (1 inline comment) Please use Resolves: in the Commit Message! Otherwise ChangeLog generation will not extract the issue number correctly!
    Resolves:
  3. Stefan Neufeind commented on patch set 2 12/21/11, 20:24

    I would prefer that you didn't submit this should wait until xliff-rollout is through
  1. Stefan Neufeind commented on patch set 2 12/21/11, 20:24

  2. Markus Klein commented on patch set 2 12/21/11, 20:24

    XLIFF is now in. Can this one go on now?
  3. Steffen Gebert uploaded patch set 2 12/21/11, 20:24

  4. Stefan Neufeind commented on patch set 3 12/21/11, 20:24

    Looks good to me, but someone else must approve fine with me. trivial change
  5. Stefan Neufeind commented on patch set 4 12/21/11, 20:24

    somebody please take a final look
  6. Stefan Neufeind commented on patch set 4 12/21/11, 20:24

    somebody ... please :-)
  7. Markus Klein uploaded patch set 4 12/21/11, 20:24

  8. Markus Klein voted on patch set 4 V 0 12/21/11, 20:24

  9. Markus Klein commented on patch set 4 12/21/11, 20:24

    Looks good to me, but someone else must approve Rebased on current master. Re-phrasing of labels should be fine.
  10. Markus Klein commented on patch set 5 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve @Oliver: Go ahead and submit it please.
  11. Oliver Hader uploaded patch set 5 12/21/11, 20:24

  12. Oliver Hader commented on patch set 5 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:1, R:1 from Markus Klein <klein.t3@mfc-linz.at> V:1, R:1 from Georg Ringer <mail@ringerge.org>
  13. Georg Ringer commented on patch set 4 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve
  14. Steffen Gebert commented on patch set 3 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve
  15. Steffen Gebert uploaded patch set 3 12/21/11, 20:24

  16. Philipp Gampe commented on patch set 3 12/21/11, 20:24

    (1 inline comment) Can we just change the label? I though we would need to introduce the new labels for changes.
    Should go to 4.5 too. So a Releases: 4.6, 4.5 line is missing
  17. Philipp Gampe commented on patch set 5 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve
  18. Jo Hasenau commented on patch set 2 12/21/11, 20:24

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 1 12/21/11, 20:24

  20. Mr. Jenkins commented on patch set 2 12/21/11, 20:24

  21. Mr. Jenkins commented on patch set 3 12/21/11, 20:24

  22. Mr. Jenkins commented on patch set 4 12/21/11, 20:24

  23. Mr. Jenkins commented on patch set 5 12/21/11, 20:24

  24. Steffen Gebert commented on patch set 5 V 0 12/21/11, 20:24

    by team member; Looks good to me, approved Submitting, as Georg gave positive team-member votes.
  25. Steffen Gebert merged patch set 5 12/21/11, 20:24