2790[BUGFIX] Adjust shortcut mode labels for selected/current page
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Markus Klein +1
- Oliver Hader +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Gebert +2
- Markus Klein +1
- Oliver Hader +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 28
Show 3 earlier messages
-
Stefan Neufeind commented on patch set 1 12/21/11, 20:24
will need to update other translations (and the newly created xliff-files) as well. Also applies to TYPO3 4.5 (same shortcut mode-functionality). -
Steffen Gebert commented on patch set 1 12/21/11, 20:24
(1 inline comment) Please use Resolves: in the Commit Message! Otherwise ChangeLog generation will not extract the issue number correctly!Resolves: -
Stefan Neufeind commented on patch set 2 12/21/11, 20:24
I would prefer that you didn't submit this should wait until xliff-rollout is through
-
Stefan Neufeind commented on patch set 2 12/21/11, 20:24
waiting for https://review.typo3.org/#change,2573 to go in -
Markus Klein commented on patch set 2 12/21/11, 20:24
XLIFF is now in. Can this one go on now? -
Steffen Gebert uploaded patch set 2 12/21/11, 20:24
-
Stefan Neufeind commented on patch set 3 12/21/11, 20:24
Looks good to me, but someone else must approve fine with me. trivial change -
Stefan Neufeind commented on patch set 4 12/21/11, 20:24
somebody please take a final look -
Stefan Neufeind commented on patch set 4 12/21/11, 20:24
somebody ... please :-) -
Markus Klein uploaded patch set 4 12/21/11, 20:24
-
Markus Klein voted on patch set 4 V 0 12/21/11, 20:24
-
Markus Klein commented on patch set 4 12/21/11, 20:24
Looks good to me, but someone else must approve Rebased on current master. Re-phrasing of labels should be fine. -
Markus Klein commented on patch set 5 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve @Oliver: Go ahead and submit it please. -
Oliver Hader uploaded patch set 5 12/21/11, 20:24
-
Oliver Hader commented on patch set 5 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:1, R:1 from Markus Klein <klein.t3@mfc-linz.at> V:1, R:1 from Georg Ringer <mail@ringerge.org> -
Georg Ringer commented on patch set 4 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 3 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 3 12/21/11, 20:24
-
Philipp Gampe commented on patch set 3 12/21/11, 20:24
(1 inline comment) Can we just change the label? I though we would need to introduce the new labels for changes.Should go to 4.5 too. So a Releases: 4.6, 4.5 line is missing -
Philipp Gampe commented on patch set 5 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 2 12/21/11, 20:24
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 12/21/11, 20:24
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/750/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/21/11, 20:24
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/753/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/21/11, 20:24
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1877/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/21/11, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2321/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/21/11, 20:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2627/ : SUCCESS -
Steffen Gebert commented on patch set 5 V 0 12/21/11, 20:24
by team member; Looks good to me, approved Submitting, as Georg gave positive team-member votes. -
Steffen Gebert merged patch set 5 12/21/11, 20:24