Review main Merged

28099[BUGFIX] ResourceStorage::SIGNAL_PreFileAdd should be triggered earlier

Xavier Perseguers CR +2 V +2 Easy +9 −6 updated 03/08/14, 16:32

Commit message

The PreFileAdd signal should be triggered before the file exist check.
So the name and/or content can be manipulated before the target filename
is checked.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 03/06/14, 10:58

  2. Frans Saris commented on patch set 1 03/06/14, 14:54

    ResourceStorage.php:2105

    Is it safe to add the param before the existing params? Not sure if slot breaks if only 2 params are defined instead of 3 (to stay backwards compatible). Maybe also pass storage and driver. Then you can call $this->driver->fileExistsInFolder() in your own code when wanted.
  3. Xavier Perseguers commented on patch set 1 03/06/14, 14:57

    ResourceStorage.php:2105 Reply

    you're right for the argument order, did not pay attention that this signal existed before 6.2
  4. Xavier Perseguers uploaded patch set 2 03/06/14, 15:13

  5. Mr. Jenkins commented on patch set 2 03/06/14, 15:26

  6. Xavier Perseguers uploaded patch set 3 03/06/14, 15:39

  7. Mr. Jenkins commented on patch set 3 03/06/14, 15:52

  8. Christian Kuhn voted on patch set 3 CR +1 03/06/14, 18:11

  9. Xavier Perseguers commented on patch set 3 03/06/14, 19:08

    if you want to test, you may do so with EXT:image_autoresize, master branch + this pending patch: https://review.typo3.org/#/c/28104/ (try without the patch here, autoresize in fileadmin/CE should not work anymore since I now use signal/slot to be notified)
  10. Christian Kuhn voted on patch set 3 V +1 03/08/14, 16:26

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/08/14, 16:32

  12. Anja Leichsenring merged patch set 4 03/08/14, 16:32